revise validate-extension-inputs.js to detect problems with percent i…#138
Open
benjiwheeler wants to merge 2 commits intoscratchfoundation:masterfrom
Open
revise validate-extension-inputs.js to detect problems with percent i…#138benjiwheeler wants to merge 2 commits intoscratchfoundation:masterfrom
benjiwheeler wants to merge 2 commits intoscratchfoundation:masterfrom
Conversation
chrisgarrity
suggested changes
Feb 3, 2021
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
This is really helpful. One simple change is to replace all the console.log with process.stdout.write. I think it's a bit clearer for command line scripts. I wouldn't use process.stderr because it isn't an error in the script itself.
Also, would it make sense to rename the script 'validate-inputs.js' as it's not just for extensions any more.
| ); | ||
| } catch (err) { | ||
| numLocaleErrors++; | ||
| console.error(err.message + '\n'); // eslint-disable-line no-console |
Contributor
There was a problem hiding this comment.
Suggested change
| console.error(err.message + '\n'); // eslint-disable-line no-console | |
| process.stdout.write(err.message + '\n'); |
It's better to use process.stdout for this type of script (also doesn't trigger eslint)
Contributor
Author
|
@chrisgarrity, we're assigning this to you to decide what to do with this one! Hope it's helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #137
Changes